split skb as soon http_parser returned TFW_PASS #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ss_skb_split() fails, a part of the next http message will be added to the end of last parsed message. If the error happened, there is no recourse, we must close the connection.
vankoven
force-pushed
the
ik-fix-msg-splitting
branch
from
4b1faed to
b024333
Compare
aleksostapenko
approved these changes
Dec 21, 2018
| @@ -1894,40 +1894,17 @@ tfw_http_conn_send(TfwConn *conn, TfwMsg *msg) | |||
| * Siblings in HTTP are pipelined HTTP messages that share the same SKB. | |||
| */ | |||
| static TfwHttpMsg * | |||
| tfw_http_msg_create_sibling(TfwHttpMsg *hm, struct sk_buff **skb, | |||
There was a problem hiding this comment.
Looks like function comment is outdated: @msg -> @hm.
tempesta_fw/http.c
Outdated
| /* | ||
| * The message is fully parsed, the rest of the data in the | ||
| * stream may represent another request or its part. | ||
| * If skb splitting has failed, the request cant be forwarded to |
There was a problem hiding this comment.
cant -> can't. The same for tfw_http_resp_process().
tempesta_fw/http.c
Outdated
| @@ -3247,6 +3249,26 @@ tfw_http_resp_process(TfwConn *conn, const TfwFsmData *data) | |||
| goto bad_msg; | |||
| } | |||
|
|
|||
| /* | |||
| * The message is fully parsed, the rest of the data in the | |||
| * stream may represent another request or its part. | |||
There was a problem hiding this comment.
request -> response
krizhanovsky
requested changes
Dec 27, 2018
| * process current one. But @skb must be freed then, since it's | ||
| * not owned by any message. | ||
| */ | ||
| if (!req_conn_close && skb) { |
There was a problem hiding this comment.
If req_conn_close and skb != NULL (i.e. there are pipelined messages), then the skb leaks - nobody frees it.
vankoven
force-pushed
the
ik-fix-msg-splitting
branch
from
4f65bde to
72ba622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ss_skb_split() fails, a part of the next http message will be added to the end of last parsed message. Forwarding such message will break response-request sequence. There is no sense to process the parsed message if split will fail: such message can't be forwarded and connection must be closed to recover.
Current master is also vulnerable for attack on response-request sequence attack:
Connection: closeheaderConnection: closeheader is not set. So no split is performed.